git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Catch failures from t5540-http-push

From
Mike Hommey <mh@glandium.org>
Date
Jul 7, 2008, 21:06 UTC
Message-ID
<1215464806-5412-1-git-send-email-mh@glandium.org>
In-Reply-To
<7vej6531xa.fsf@gitster.siamese.dyndns.org>

git http-push doesn't handle packed-refs, and now the new builtin-clone created packed refs, the http-push test fails.

Mark the current failure as such, and also catch third test's failure
that went unreported because git push doesn't return an error code when
it says:
 No refs in common and none specified; doing nothing.
Which it does when http-push can't get a list of refs recursively from
$URL/refs/.
Signed-off-by: Mike Hommey <mh@glandium.org>
---
 Feel free to squash this in the previous one, if you feel it's better.
 t/t5540-http-push.sh |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/t/t5540-http-push.sh b/t/t5540-http-push.sh
index 147ff98..21dbb55 100755
--- a/t/t5540-http-push.sh
+++ b/t/t5540-http-push.sh
@@ -51,16 +51,17 @@ test_expect_success 'clone remote repository' '
 	git clone $HTTPD_URL/test_repo.git test_repo_clone
 '
 
-test_expect_success 'push to remote repository' '
+test_expect_failure 'push to remote repository' '
 	cd "$ROOT_PATH"/test_repo_clone &&
 	: >path2 &&
 	git add path2 &&
 	test_tick &&
 	git commit -m path2 &&
-	git push
+	git push &&
+	[ -f "$HTTPD_DOCUMENT_ROOT_PATH/test_repo.git/refs/heads/master" ]
 '
 
-test_expect_success 'create and delete remote branch' '
+test_expect_failure 'create and delete remote branch' '
 	cd "$ROOT_PATH"/test_repo_clone &&
 	git checkout -b dev &&
 	: >path3 &&
-- 
1.5.6.GIT
Previous: Mike Hommey
Message 5 of 5 in “Fix http-push test”
  1. Fix http-push testMike Hommey, Jul 7, 2008
  2. Mike HommeyJul 7, 2008
  3. Junio C HamanoJul 7, 2008
  4. Mike HommeyJul 7, 2008
  5. Catch failures from t5540-http-pushMike Hommey, Jul 7, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.