Re: [PATCH] bisect: avoid pipes to better catch "git rev-list" errors

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 11, 2009, 00:52 UTC
Message-ID: <7veiw0nh9c.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20090410093436.6117@nanako3.lavabit.com>

Nanako Shiraishi <nanako3@lavabit.com> writes:

Show 24 quoted lines

> Quoting Christian Couder:
>
>> When doing:
>> 
>> eval "git rev-list --bisect-vars ..." | {
>>         while read line
>>         do
>>                 echo "$line &&"
>>         done
>>         echo ':'
>> }
>> 
>> the result code comes from the last "echo ':'", not from running
>> "git rev-list --bisect-vars ...".
>> 
>> This means that we may miss errors from "git rev-list".
>> 
>> To fix that, this patch gets rid of the pipes by redirecting the
>> output of "git rev-list" into a file, and then reading from this
>> file.
>> 
>> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
>
> Junio, may I ask what happened to this patch?

I've chosen to ignore it, hoping that Christian's other bisect topic to stabilize soon. That will make this patch unnecessary, I think.