threads / patch / 18616

patchbisect: avoid pipes to better catch "git rev-list" errors

Subject: [PATCH] bisect: avoid pipes to better catch "git rev-list" errors

## tl;dr

3 messages between Mar 29, 2009 and Apr 11, 2009. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Christian Couder· Mar 29, 2009, 09:58 UTC · lore

When doing:

eval "git rev-list --bisect-vars ..." | {
        while read line
        do
                echo "$line &&"
        done
        echo ':'
}

the result code comes from the last "echo ':'", not from running "git rev-list --bisect-vars ...".

This means that we may miss errors from "git rev-list".

To fix that, this patch gets rid of the pipes by redirecting the output of "git rev-list" into a file, and then reading from this file.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 git-bisect.sh |   16 ++++++++++------
 1 files changed, 10 insertions(+), 6 deletions(-)

This applies to master.

Show changes to git-bisect.sh +10 −6

diff --git a/git-bisect.sh b/git-bisect.sh
index e313bde..45214ca 100755
--- a/git-bisect.sh
+++ b/git-bisect.sh
@@ -284,19 +284,22 @@ filter_skipped() {
 	_skip="$2"
 
 	if [ -z "$_skip" ]; then
-		eval "$_eval" | {
+		eval "$_eval" > "$GIT_DIR/BISECT_EVAL_TMP" &&
+		{
 			while read line
 			do
 				echo "$line &&"
-			done
+			done < "$GIT_DIR/BISECT_EVAL_TMP" &&
 			echo ':'
-		}
+		} &&
+		rm -f "$GIT_DIR/BISECT_EVAL_TMP"
 		return
 	fi
 
 	# Let's parse the output of:
 	# "git rev-list --bisect-vars --bisect-all ..."
-	eval "$_eval" | {
+	eval "$_eval" > "$GIT_DIR/BISECT_EVAL_TMP" &&
+	{
 		VARS= FOUND= TRIED=
 		while read hash line
 		do
@@ -349,9 +352,10 @@ filter_skipped() {
 				    "line: '$line'"
 				;;
 			esac
-		done
+		done < "$GIT_DIR/BISECT_EVAL_TMP" &&
 		echo ':'
-	}
+	} &&
+	rm -f "$GIT_DIR/BISECT_EVAL_TMP"
 }
 
 exit_if_skipped_commits () {

-- 
1.6.2.1.404.gb0085.dirty

Nanako Shiraishi· Apr 10, 2009, 00:34 UTC · re: Christian Couder · lore

Re: [PATCH] bisect: avoid pipes to better catch "git rev-list" errors

Quoting Christian Couder:

Show 20 quoted lines

> When doing:
> 
> eval "git rev-list --bisect-vars ..." | {
>         while read line
>         do
>                 echo "$line &&"
>         done
>         echo ':'
> }
> 
> the result code comes from the last "echo ':'", not from running
> "git rev-list --bisect-vars ...".
> 
> This means that we may miss errors from "git rev-list".
> 
> To fix that, this patch gets rid of the pipes by redirecting the
> output of "git rev-list" into a file, and then reading from this
> file.
> 
> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>

Junio, may I ask what happened to this patch?

-- 
Nanako Shiraishi
http://ivory.ap.teacup.com/nanako3/

Junio C Hamano· Apr 11, 2009, 00:52 UTC · re: Nanako Shiraishi · lore

Re: [PATCH] bisect: avoid pipes to better catch "git rev-list" errors

Nanako Shiraishi <nanako3@lavabit.com> writes:

Show 24 quoted lines

> Quoting Christian Couder:
>
>> When doing:
>> 
>> eval "git rev-list --bisect-vars ..." | {
>>         while read line
>>         do
>>                 echo "$line &&"
>>         done
>>         echo ':'
>> }
>> 
>> the result code comes from the last "echo ':'", not from running
>> "git rev-list --bisect-vars ...".
>> 
>> This means that we may miss errors from "git rev-list".
>> 
>> To fix that, this patch gets rid of the pipes by redirecting the
>> output of "git rev-list" into a file, and then reading from this
>> file.
>> 
>> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
>
> Junio, may I ask what happened to this patch?

I've chosen to ignore it, hoping that Christian's other bisect topic to stabilize soon. That will make this patch unnecessary, I think.