Re: [PATCH] bisect: remove Perl use by implementing "git bisect--helper --sq-quote"
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 22, 2009, 06:03 UTC
- Message-ID
- <7veivl444b.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20090422045524.3606.81842.chriscool@tuxfamily.org>
Christian Couder <chriscool@tuxfamily.org> writes:
> The sq() function in "git-bisect.sh" was the only place where Perl > was needed. This patch remove this use of Perl by implementing > a new "--sq-quote" option in "builtin-bisect--helper.c".
Isn't it because only git-bisect.sh for whatever reason reimplements sq using Perl while original implementation in am used sed for more portability?
I would suspect, if it were 3 years ago, that any serious porcelain writers would have very much appreciated such a feature that gives shell programmers an easy access to a quoting function that allows a safe eval, and I would have strongly suggested that the feature to be implemented in a more permanent place rather than in bisect--helper; perhaps a better place would be the kitchen-sink "rev-parse".
But given that nobody seems competent enough to do serious programming in shell these days, I am not sure if the choice between bisect--helper and rev-parse makes much of a difference ;-).