git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix gitmkdtemp: correct test for mktemp() return value

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 25, 2010, 17:33 UTC
Message-ID
<7veik99q4q.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4B864A7B.9000500@flexerasoftware.com>
Filippo Negroni <fnegroni@flexerasoftware.com> writes:
Show 12 quoted lines
> From 5e3b362cdd86150de901312c01beac9596b7e2ba Mon Sep 17 00:00:00 2001
> From: Filippo Negroni <fnegroni@flexerasoftware.com>
> Date: Thu, 25 Feb 2010 09:39:56 +0000
> Subject: [PATCH] Fix gitmkdtemp: correct test for mktemp() return value
>
> In gitmkdtemp, the return value of mktemp is not tested correctly.
> mktemp() always returns its 'template' argument, even upon failre.
> Upon failure, mktemp sets template to be an empty string: its first character is '\0'.
> This patch ensures the return value of mktemp is correctly tested by dereferencing the pointer returned by it.
>
> Signed-off-by: Filippo Negroni <fnegroni@flexerasoftware.com>
> ---
Thanks.

Next time please do not quote the mbox header lines (i.e. start your body with "In gitmkdtemp, the return value ...".

Previous: Filippo NegroniNext: Matthieu Moy
Message 2 of 3 in “Fix gitmkdtemp: correct test for mktemp() return value”
  1. Fix gitmkdtemp: correct test for mktemp() return valueFilippo Negroni, Feb 25, 2010
  2. Junio C HamanoFeb 25, 2010
  3. Matthieu MoyFeb 25, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.