From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 25 Feb 2010 17:33:41 GMT
Subject: Re: [PATCH] Fix gitmkdtemp: correct test for mktemp() return value
Message-ID: <7veik99q4q.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4B864A7B.9000500@flexerasoftware.com>

Filippo Negroni <fnegroni@flexerasoftware.com> writes:

> From 5e3b362cdd86150de901312c01beac9596b7e2ba Mon Sep 17 00:00:00 2001
> From: Filippo Negroni <fnegroni@flexerasoftware.com>
> Date: Thu, 25 Feb 2010 09:39:56 +0000
> Subject: [PATCH] Fix gitmkdtemp: correct test for mktemp() return value
>
> In gitmkdtemp, the return value of mktemp is not tested correctly.
> mktemp() always returns its 'template' argument, even upon failre.
> Upon failure, mktemp sets template to be an empty string: its first character is '\0'.
> This patch ensures the return value of mktemp is correctly tested by dereferencing the pointer returned by it.
>
> Signed-off-by: Filippo Negroni <fnegroni@flexerasoftware.com>
> ---

Thanks.

Next time please do not quote the mbox header lines (i.e. start your body
with "In gitmkdtemp, the return value ...".