Re: [patch 11/15] no-hstrerror.patch
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 16, 2010, 07:24 UTC
- Message-ID
- <7veijkn2yo.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20100316054352.704479000@mlists.thewrittenword.com>
"Gary V. Vaughan" <git@mlists.thewrittenword.com> writes:
Show 23 quoted lines
> SunOS 5.6 and 5.5.1 do not have hstrerror, even in libresolv. > > This patch improves the logic of the test for hstrerror, not to > blindly assume that if there is no hstrerror in libc that it must > exist in libresolv. > --- > Makefile | 1 + > config.mak.in | 1 + > configure.ac | 17 ++++++++++++++--- > 3 files changed, 16 insertions(+), 3 deletions(-) > > Index: b/configure.ac > =================================================================== > --- a/configure.ac > +++ b/configure.ac > @@ -526,11 +526,22 @@ test -n "$NEEDS_SOCKET" && LIBS="$LIBS - > > # > # Define NEEDS_RESOLV if linking with -lnsl and/or -lsocket is not enough. > -# Notably on Solaris hstrerror resides in libresolv and on Solaris 7 > -# inet_ntop and inet_pton additionally reside there. > -AC_CHECK_LIB([c], [hstrerror], > +# Notably on Solaris 7 inet_ntop and inet_pton additionally reside there.
You lost the thing they are "additional" to, so this needs a bit of rewording?
Other than that the patch looked sane (I don't have access to any vintage of Solaris these days, so I only read it through, though).
Thanks.