Re: [patch 07/15] host-IRIX.patch

From: Gary V. Vaughan <git@mlists.thewrittenword.com>
Date: Apr 25, 2010, 08:39 UTC
Message-ID: <20100316085459.GD26540@thor.il.thewrittenword.com>
In-Reply-To: <7vljdsn2yz.fsf@alter.siamese.dyndns.org>

On Tue, Mar 16, 2010 at 12:24:36AM -0700, Junio C Hamano wrote:

Show 12 quoted lines

> "Gary V. Vaughan" <git@mlists.thewrittenword.com> writes:
> 
> > Irix 6.5 does not define 'sgi', but does define '__sgi'.
> >
> > Also, Irix 6.5 requires _BSD_TYPES to be defined in order for the BSD
> > u_short types et. al. to be declared properly.
> 
> If Irix 6.5 defines __sgi and the patch _adds_ "defined(__sgi)" I wouldn't
> have to worry too much, but would replacing "defined(sgi)" with the
> double-underscore version make somebody who added "defined(sgi)" in the
> first place cry, if it was done for different version of Irix that does
> define "sgi" (worse yet, but not "__sgi")?

Agreed. I've amended my local version of this patch to check both (sgi) and (__sgi) now. Thanks.

> Another natural question is if defining _BSD_TYPES everywhere has negative
> effects on somebody else's platforms, but that is what people on different
> platforms will have to apply this patch, test, and report success or
> breakage.  Help from the list audience is appreciated.

Good point.  Perhaps better to make that change in the Makefile?

ifeq ($(uname_S),IRIX64)
        # Need this for u_short definitions et al
        BASIC_CFLAGS += -D_BSD_TYPES
endif

I only have use of mips-sgi-irix6.5 machines, so I'm not sure what other versions are affected... probably a safe bet that ifeq($(uname_S),IRIX) should get that definition too.

Cheers,

-- 
Gary V. Vaughan (gary@thewrittenword.com)