git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv5 2/6] Gitweb: add support for minifying gitweb.css

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 15, 2010, 00:46 UTC
Message-ID
<7veiihmtjw.fsf@alter.siamese.dyndns.org>
In-Reply-To
<201004150225.42101.jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> writes:
>> -gitweb.cgi: gitweb.perl $(GITWEB_JS) $(GITWEB_CSS)
>> +gitweb.cgi: gitweb.perl
> ...
> That makes gitweb.cgi not depend on gitweb.min.js, not gitweb.min.css.
That is what I inteded to do.

Unless you are including gitweb.cgi (iow, the contents of the generated file depends on the _contents_ of gitweb.min.js (or gitweb.js), gitweb.cgi does _not_ depend on these files. Of course if you generate gitweb.cgi out of gitweb.perl with one setting of GITWEB_JS and then change your mind, then you need to regenerate it, but that is not something you can do by comparing file timestamp of gitweb.cgi and the file timestamp of $(GITWEB_JS) anyway. You would need to imitate something like how GIT-BUILD-OPTIONS is used by the primary Makefile.

Previous: Jakub NarebskiNext: Jakub Narebski
Message 12 of 15 in “[PATCHv5 2/6] Gitweb: add support for minifying gitweb.css”
  1. Mark RadaApr 1, 2010
  2. Jakub NarebskiApr 1, 2010
  3. Charles BaileyApr 13, 2010
  4. Jakub NarebskiApr 13, 2010
  5. Mark RadaApr 14, 2010
  6. Jakub NarebskiApr 14, 2010
  7. Mark RadaApr 14, 2010
  8. Jakub NarebskiApr 14, 2010
  9. Junio C HamanoApr 14, 2010
  10. Charles BaileyApr 15, 2010
  11. Jakub NarebskiApr 15, 2010
  12. Junio C HamanoApr 15, 2010
  13. Jakub NarebskiApr 15, 2010
  14. Mark RadaApr 15, 2010
  15. Junio C HamanoApr 15, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.