Re: [PATCHv5 2/6] Gitweb: add support for minifying gitweb.css

From: Charles Bailey <charles@hashpling.org>
Date: Apr 15, 2010, 00:18 UTC
Message-ID: <20100415001830.GA26416@hashpling.org>
In-Reply-To: <7viq7tmvsb.fsf@alter.siamese.dyndns.org>

On Wed, Apr 14, 2010 at 04:58:12PM -0700, Junio C Hamano wrote:

Show 25 quoted lines

> Jakub Narebski <jnareb@gmail.com> writes:
> 
> > On Tue, 13 April 2010, Charles Bailey wrote:
> >> On 01/04/2010 06:36, Mark Rada wrote:
> >> > @@ -84,13 +92,14 @@ endif
> >> >
> >> >   all:: gitweb.cgi
> >> >
> >> > +FILES = gitweb.cgi
> >> >   ifdef JSMIN
> >> > +FILES += gitweb.min.js
> >> > +endif
> >> > +ifdef CSSMIN
> >> > +FILES += gitweb.min.css
> >> > +endif
> >> > +gitweb.cgi: gitweb.perl $(GITWEB_JS) $(GITWEB_CSS)
> >
> > GITWEB_JS and GITWEB_CSS were originally meant to be URI to file with
> > gitweb JavaScript code and default gitweb stylesheet,... but during work
> > on minification of JavaScript code and CSS file it somehow got confused
> > to mean source path.
> 
> I am not touching instaweb part, but this would fix the build/clean side
> of the things, no?
>

Yes, this certainly fixes make and make clean for me with overridden GITWEB_JS and GITWEB_CSS paths.

Charles.