Re: [PATCH] git-cvs*: Make building (and testing) of CVS interface scripts optionally selectable
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 7, 2011, 23:50 UTC
- Message-ID
- <7vei8o46jy.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <robbat2-20110107T225413-429815896Z@orbis-terrarum.net>
"Robin H. Johnson" <robbat2@gentoo.org> writes:
Show 8 quoted lines
> On Fri, Jan 07, 2011 at 04:01:48PM -0600, Jonathan Nieder wrote: >> This explanation seems quite odd to me. Are you saying we can't rely >> on the 'cvs' name being "taken" and should live in fear that someone >> will implement an incompatible utility with the same name? Did that >> actually happen? > Not in the linked bug report, but it does explain a previous bug I had > seen, where a user had a little script in /usr/local/bin that complained > at him whenever he ran 'cvs', so he would learn to migrate away faster.
I suspect that NO_CVS is not the best way to help a person who is trying to wean herself off of cvs by having a phony cvs in a directory that is early on the $PATH (be it $HOME/bin/cvs or /usr/local/bin/cvs). Before ceasing to actively build more histories in cvs, it would help to have an access to git-cvsimport and friends to salvage what's already there, no?
A change that models after PERL_PATH, not after NO_PERL, would be a more appropriate thing to do for that particular purpose.
I still think the patch itself is a worthy thing to have, so everything above is a tangent that is orthogonal to what your patch tries to do, though.