Re: [PATCH] git-cvs*: Make building (and testing) of CVS interface scripts optionally selectable

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jan 7, 2011, 22:01 UTC
Message-ID: <20110107220147.GB9194@burratino>
In-Reply-To: <1294433290-9262-1-git-send-email-robbat2@gentoo.org>

Robin H. Johnson wrote:

> Presently, the CVS interface scripts are always built, and their
> test-suites run based on a binary named 'cvs' happening to return zero.
> If there something other than the real CVS there, bad things happened
> during the test-suite run.

This explanation seems quite odd to me. Are you saying we can't rely on the 'cvs' name being "taken" and should live in fear that someone will implement an incompatible utility with the same name? Did that actually happen?

I would find it easier to believe

	Building and testing git's cvs support is slow, because ...

	So give users with no interest in cvs interoperability a way
	out.  By defining NO_CVS you can avoid this time-consuming
	piece of the build process.

Or for a different patch:

	Add a NO_CVS knob so users with no interest in cvs support
	can avoid polluting their $(libexecdir) with unwanted entries.

Or:

	Introduce a new NO_CVS knob.  If set, the CVS interop scripts
	will be replaced by unimplemented.sh so sysadmins and
	distributors can hopefully get a nice, clear error report instead
	of confusion when users try to run them with cvs not installed.