git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2-3/3] Name make_*_path functions more accurately

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 16, 2011, 20:48 UTC
Message-ID
<7vei667pws.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1300299469.3995.10.camel@centaur>
Carlos Martín Nieto <cmn@elego.de> writes:
Show 11 quoted lines
> On Wed, 2011-03-16 at 17:59 +0100, Michael J Gruber wrote:
>> Why remove the check? Again, this is not just renaming.
>
>  Semantics change. Same as above. The one below (snipped) is the same.
>>>[...]
>> I think you should strictly separate the renaming issue from other
>> patches (and describe/motivate the latter). It's fine to have a large
>> patch with mechanical changes (renaming) if you stick to just those.
>
>  Unfortunately I introduced some modifications trying to reduce the
> number of times we call make_absolute_path/real_path and they snuck in.
Michael, thanks for helping with good eyes.
Previous: Carlos Martín Nieto
Message 4 of 4 in “Name make_*_path functions more accurately”
  1. 3/3 Name make_*_path functions more accuratelyCarlos Martín Nieto, Mar 16, 2011
  2. Michael J GruberMar 16, 2011
  3. Carlos Martín NietoMar 16, 2011
  4. Junio C HamanoMar 16, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.