From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 16 Mar 2011 20:48:19 GMT
Subject: Re: [PATCH 2-3/3] Name make_*_path functions more accurately
Message-ID: <7vei667pws.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1300299469.3995.10.camel@centaur>

Carlos Martín Nieto <cmn@elego.de> writes:

> On Wed, 2011-03-16 at 17:59 +0100, Michael J Gruber wrote:
>> Why remove the check? Again, this is not just renaming.
>
>  Semantics change. Same as above. The one below (snipped) is the same.
>>>[...]
>> I think you should strictly separate the renaming issue from other
>> patches (and describe/motivate the latter). It's fine to have a large
>> patch with mechanical changes (renaming) if you stick to just those.
>
>  Unfortunately I introduced some modifications trying to reduce the
> number of times we call make_absolute_path/real_path and they snuck in.

Michael, thanks for helping with good eyes.