Re: git 1.8.0.rc0.18.gf84667d trouble with "git commit -p file"

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 7, 2012, 22:23 UTC
Message-ID: <7vehl9q5uk.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20121007214958.GC1743@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 21 quoted lines

> On Sun, Oct 07, 2012 at 01:51:21PM -0700, Junio C Hamano wrote:
>
>> Jeff King <peff@peff.net> writes:
>> 
>> > Which is obviously one of:
>> >
>> >   1. Keep defaulting to "--include", as that is what we have been doing.
>> >
>> >   2. Forbid the cases where it would matter (i.e., when the index and
>> >      HEAD differ).
>> >
>> > The former is more convenient, but the latter is safer against
>> > future breakage. I'm OK either way, but option (1) clearly needs a
>> > documentation update.
>> 
>> Yeah, I agree with the reasoning.  This is an unessential feature
>> that is with the problem for a long time, so let's go the route #1
>> first before we do anything else.
>
> OK. I think Conrad's patch takes us most of the way there. I had a few
> minor comments, but I think another round should do it. Conrad?

I'd rather want to see a patch that _only_ documents the current behaviour to unconfuse people first. I definitely do not want any patch that changes the command line parsing or any other behaviour change with problems that have to take time from reviewers to point them out mixed in it.