git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git 1.8.0.rc0.18.gf84667d trouble with "git commit -p file"

From
Jeff King <peff@peff.net>
Date
Oct 7, 2012, 22:25 UTC
Message-ID
<20121007222502.GA3263@sigill.intra.peff.net>
In-Reply-To
<7vehl9q5uk.fsf@alter.siamese.dyndns.org>
On Sun, Oct 07, 2012 at 03:23:31PM -0700, Junio C Hamano wrote:
Show 12 quoted lines
> >> Yeah, I agree with the reasoning.  This is an unessential feature
> >> that is with the problem for a long time, so let's go the route #1
> >> first before we do anything else.
> >
> > OK. I think Conrad's patch takes us most of the way there. I had a few
> > minor comments, but I think another round should do it. Conrad?
> 
> I'd rather want to see a patch that _only_ documents the current
> behaviour to unconfuse people first.  I definitely do not want any
> patch that changes the command line parsing or any other behaviour
> change with problems that have to take time from reviewers to point
> them out mixed in it.

Sorry, I should have been more clear. I want to see a re-roll of only the documentation bits of Conrad's patch, for which I had only minor comments. The code part had major problems. :)

-Peff
Previous: Junio C HamanoNext: Conrad Irwin
Message 14 of 16 in “git 1.8.0.rc0.18.gf84667d trouble with "git commit -p file"”
  1. Horst H. von BrandOct 5, 2012
  2. Frans KlaverOct 5, 2012
  3. Junio C HamanoOct 5, 2012
  4. Jeff KingOct 5, 2012
  5. Junio C HamanoOct 6, 2012
  6. Jeff KingOct 6, 2012
  7. Junio C HamanoOct 6, 2012
  8. Jeff KingOct 6, 2012
  9. Conrad IrwinOct 6, 2012
  10. Jeff KingOct 6, 2012
  11. Junio C HamanoOct 7, 2012
  12. Jeff KingOct 7, 2012
  13. Junio C HamanoOct 7, 2012
  14. Jeff KingOct 7, 2012
  15. Conrad IrwinOct 11, 2012
  16. Junio C HamanoOct 11, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.