Re: [PATCH 3/3] cvsimport: start adding cvsps 3.x support

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 15, 2013, 06:44 UTC
Message-ID: <7vehhn54jq.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAEUsAPZV6rdFz5R6NN55qYr5se4bFJftE0xGSPAtXLp8jcO0vw@mail.gmail.com>

Chris Rorvick <chris@rorvick.com> writes:

[jc: please elide parts you are not responding to, leaving enough lines to understand the context]

Show 7 quoted lines

>> +    def command(self):
>> +        "Emit the command implied by all previous options."
>> +        return self.cvsps + "--fast-export " + self.opts
>
> "--fast-export" string is missing a leading space.  With this fix and
> the latest cvsps build I'm seeing 6 of 15 failures for t9650 which is
> what I was getting out of the patched t9600.

Thanks; I'll amend it and push the result out, but I think we will need to rip this part out and form the command string in a saner way (e.g. if the path needs to have SP in it, e.g. "/Program Files/cvsps3", the above would not work correctly anyway).