Re: [PATCH] t/lib-cvs: cvsimport no longer works without Python >= 2.7
- From
John Keeping <john@keeping.me.uk>
- Date
- Jan 13, 2013, 17:17 UTC
- Message-ID
- <20130113171720.GM4574@serenity.lan>
- In-Reply-To
- <50F180E8.8010907@alum.mit.edu>
On Sat, Jan 12, 2013 at 04:27:36PM +0100, Michael Haggerty wrote:
Show 15 quoted lines
>> Even if we were to rip out the fallback code that uses the 2.7-only >> subprocess.check_output() on "cvsps -V", the function is also used >> for doing the real work interacting with cvsps-3.x, so I think this >> patch will be necessary. Unless new cvsimport is tweaked not to >> use the method, that is. >> >> A suggestion for a better alternative is of course very much >> appreciated. > > If the only reason to require Python 2.7 is subprocess.check_output(), > it would be easy to reimplement it (it is only 12 lines of > straightforward code, plus a few lines to define the exception type > CalledProcessError). According to [1], the Python license is > GPL-compatible; therefore these lines could even be copied into > git-cvsimport.
Note that this has already be done in git_remote_helpers.util. Is there any reason not to just reference that?
John