Re: "git revert" (Re: pci_update_resource() getting called on sparc64)

From: Junio C Hamano <junkio@cox.net>
Date: Aug 8, 2005, 22:47 UTC
Message-ID: <7vd5oo11wj.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.58.0508081444040.3258@g5.osdl.org>

Linus Torvalds <torvalds@osdl.org> writes:

> Or if you want to be more CVS-like, use "-F", and accept "-" for stdin?

Yes my vote goes:

	-m "message"
        -c "from this commit, literally."
        -C "from this commit, but let me edit the log further."
        -F "from this file."
        -F - <stdin

> But I like "test -t 0" regardless. Very few editors are ok with non-tty
> stdin, although I could imagine some disturbed individual having "ed" as
> their editor and expecting to be able to pipe commands into it or
> something.

I am a disturbed individual who always works in Emacs and run "git commit" in the compilation buffer, setting EDITOR to emacsclient. Admittably the compilation buffer uses pty, so "test -t 0" would succeed, though.