Re: Improve "git grep" flags handling

From: Junio C Hamano <junkio@cox.net>
Date: Sep 12, 2005, 22:37 UTC
Message-ID: <7vd5nd7w0x.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.58.0509121519310.3266@g5.osdl.org>

Linus Torvalds <torvalds@osdl.org> writes:

Show 5 quoted lines

> +  # git-ls-file specific flags
> +  --others|--exclude=*|--exclude-from=*|--exclude-per-directory=*)
> +      git_flags="$git_flags $pattern"
> +      shift
> +      ;;

This would not fly well, I am afraid. --exclude=* are usually shell globs which would be expanded before you use them unquoted.