From: Junio C Hamano Date: Mon, 12 Sep 2005 22:37:18 GMT Subject: Re: Improve "git grep" flags handling Message-ID: <7vd5nd7w0x.fsf@assigned-by-dhcp.cox.net> In-Reply-To: Linus Torvalds writes: > + # git-ls-file specific flags > + --others|--exclude=*|--exclude-from=*|--exclude-per-directory=*) > + git_flags="$git_flags $pattern" > + shift > + ;; This would not fly well, I am afraid. --exclude=* are usually shell globs which would be expanded before you use them unquoted.