git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [BUG] git-fetch -k is broken

From
Junio C Hamano <junkio@cox.net>
Date
Nov 30, 2006, 21:21 UTC
Message-ID
<7vd574iqa0.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<Pine.LNX.4.64.0611301441440.9647@xanadu.home>
Nicolas Pitre <nico@cam.org> writes:
Show 6 quoted lines
> Actually, the .keep file is simply not removed as it should.
>
> But first it appears that commit f64d7fd2 added an && on line 431 of 
> git-fetch.sh and that cannot be right.  There is simply no condition for 
> not removing the lock file.  It must be removed regardless if the 
> previous command succeeded or not.  Junio?

True, but your "echo" patch breaks things even more -- when fast forward check fails, it should cause the entire command should report that with the exit status.

That suggests that we need to come up with a way to clean up these .keep files some other way than just being one of the command near the end. As to the mysterious "echo e <empty>" I will not have chance to look at it myself until later today (I'm at work now and it is not my git day today).

Previous: Nicolas PitreNext: Nicolas Pitre
Message 2 of 5 in “[BUG] git-fetch -k is broken”
  1. Nicolas PitreNov 30, 2006
  2. Junio C HamanoNov 30, 2006
  3. Nicolas PitreDec 29, 2006
  4. Junio C HamanoDec 29, 2006
  5. git-fetch: remove .keep file even on other errors.Junio C Hamano, Jan 1, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.