From: Junio C Hamano <junkio@cox.net>
Date: Thu, 30 Nov 2006 21:21:59 GMT
Subject: Re: [BUG] git-fetch -k is broken
Message-ID: <7vd574iqa0.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.64.0611301441440.9647@xanadu.home>

Nicolas Pitre <nico@cam.org> writes:

> Actually, the .keep file is simply not removed as it should.
>
> But first it appears that commit f64d7fd2 added an && on line 431 of 
> git-fetch.sh and that cannot be right.  There is simply no condition for 
> not removing the lock file.  It must be removed regardless if the 
> previous command succeeded or not.  Junio?

True, but your "echo" patch breaks things even more -- when fast
forward check fails, it should cause the entire command should
report that with the exit status.

That suggests that we need to come up with a way to clean up
these .keep files some other way than just being one of the
command near the end.  As to the mysterious "echo e <empty>"
I will not have chance to look at it myself until later today
(I'm at work now and it is not my git day today).