Re: git-add--interactive works only in top level

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 4, 2007, 17:45 UTC
Message-ID: <7vd4tm5p7a.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <Pine.LNX.4.64.0712041148310.27959@racer.site>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 12 quoted lines

>> Here he have two options: blame the user for his/her stupidity, or look 
>> at this a UI problem and try to make the UI "idiot proof".
>> 
>> In this particular case I see no impediment to favouring the second 
>> option, because we're not talking about making changes that would make 
>> Git less powerful or useful for "non-idiots", "power users" or "real 
>> men" (whatever you want to call them). In other words, we are not 
>> talking about "dumbing down" Git for the sake of the ignorant. This is 
>> an opportunity to polish the UI in the same way that we polish the 
>> internal pack format.
>
> You know, without patches you will not convince me ;-)

Honestly, I do not want a patch for that to git-add--interactive.

Once WIncent's and Dan's UI enhancements to it becomes stable (not implementation-wise but more interface- and user-experience-wise), rewriting it in C should not be too much of a hassle. When that happens, it won't be a standalone program but will be a function builtin-add.c::interactive_add() will call into and we won't have this problem at that point. If somebody does do a patch, the time is better spent there instead.