Re: git-add--interactive works only in top level
- From
- Reid Barton <rwbarton@mit.edu>
- Date
- Dec 4, 2007, 06:07 UTC
- Message-ID
- <4BC1648E-3059-4373-B388-65AD739796D8@MIT.EDU>
- In-Reply-To
- <7vwsrv9fos.fsf@gitster.siamese.dyndns.org>
On Dec 4, 2007, at 12:44 AM, Junio C Hamano wrote:
Show 6 quoted lines
> Sheesh, you got me worried. > > This is a non issue; git-add--interactive is not for direct end user > consumption. It relies on being run from git-add wrapper, which does > cdup to the top of the work tree before launching add--interactive > helper.
Ah, OK. Would it not be easy then to add a check to the beginning of git-add--interactive to verify that it is indeed being run from the top of the work tree? A user may well discover git-add--interactive before git-add --interactive (e.g. by shell completion) and if git- add--interactive is going to fail, it should do so right away so as to not confuse the user.
I understand that programs such as git-add--interactive will be moved out of the executable path not too long from now, which will also ameliorate the situation.
Regards, Reid Barton