Re: [PATCH 1/2] help: use man viewer path from "man.<tool>.path" config var

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 21, 2008, 08:56 UTC
Message-ID: <7vd4poqwu6.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <200803210823.47899.chriscool@tuxfamily.org>

Christian Couder <chriscool@tuxfamily.org> writes:

Show 9 quoted lines

> Le jeudi 20 mars 2008, Junio C Hamano a écrit :
> ...
>> If that inconsistency bothers you, you probably should rename the
>> built-in konqueror support to "kfmclient", which is more honest approach,
>> I would think.
>
> It's perhaps more honest, but kfmclient is not as well known as konqueror.
>
> Isn't a documentation patch like this enough:

I dunno.  I am not a KDE use to begin with.

But I am somewhat uncomfortable with this kind of magic, and very much more so with basing the magic on the name of a binary.

For example, if a distro offers two versions of konq to co-exist on the same system as konqueror-3 and konqueror-4 (with the usual symlink tricks /etc/alternatives/konqueror -> konqueror-3 and /usr/bin/konqueror -> /etc/alternatives/konqueror to make one version the systemwide default), people who want a particular version may say /usr/bin/konqueror-4 and would get frustrated to see kfmclient magic would not kick in. By taking honest route without magic, you would not have to worry about such potential confusion.