git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] help: use man viewer path from "man.<tool>.path" config var

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 18, 2008, 19:02 UTC
Message-ID
<7vabkv7t4c.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20080318062236.7b5e515f.chriscool@tuxfamily.org>
Christian Couder <chriscool@tuxfamily.org> writes:
Show 6 quoted lines
> This makes it possible to use different version of the tools
> than the one on the current PATH, or maybe a custom script.
>
> In this patch we also try to launch "konqueror" using
> "kfmclient" even if a path to a konqueror binary is given
> in "man.konqueror.path".

It may be true that allowing customizable paths may be more useful than not allowing them, so I do not have fundamental objection to this enhancement. However, I doubt this s/konqueror/kfmclient/ is a good idea.

As a general rule, if you allow the user to explicitly say "instead of what you would normally use, use _this_", you should not try to outsmart the user by using something else that you derived from that "_this_" the user gave you.

If the user wants to use kfmclient, then the user can say so. If the user wants to really launch konq instead of using kfmclient for whatever reason, the outsmarting code will interfere and make it impossible.

Previous: Christian CouderNext: Christian Couder
Message 2 of 11 in “help: use man viewer path from "man.<tool>.path" config var”
  1. 1/2 help: use man viewer path from "man.<tool>.path" config varChristian Couder, Mar 18, 2008
  2. Junio C HamanoMar 18, 2008
  3. Christian CouderMar 20, 2008
  4. Junio C HamanoMar 20, 2008
  5. Christian CouderMar 21, 2008
  6. Junio C HamanoMar 21, 2008
  7. Christian CouderMar 25, 2008
  8. Junio C HamanoMar 25, 2008
  9. Christian CouderMar 26, 2008
  10. Xavier MaillardMar 23, 2008
  11. Xavier MaillardMar 21, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.