Re: [PATCH 44/47] Remove all logic from get_git_work_tree()
Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:
Show 20 quoted lines
> 2010/12/22 Junio C Hamano <gitster@pobox.com>:
>>> const char *get_git_work_tree(void)
>>> {
>>> - if (startup_info && !startup_info->setup_explicit) {
>>> -...
>>> - }
>>> return work_tree;
>>> }
>>
>> Would it be a bug in the new set-up code if this function gets called and
>> work_tree is still NULL?
>>
>> There are quite a few callers that call get_git_work_tree() and expect
>> that it will always return a non NULL pointer. Perhaps we would want an
>> assertion here?
>>
>
> While the assertion sounds good, it does not work well. The old
> function can return NULL in bare repos. is_bare_repository() and
> is_inside_work_tree() expect NULL from get_git_work_tree() sometimes.Ok, don't bother changing anything in that case---it won't help us much.
Junio C Hamano <gitster@pobox.com>