[PATCH/RFC 0/3] trace: omit noisy repository discovery report
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Jan 26, 2011, 00:49 UTC
- Message-ID
- <20110126004915.GA11230@burratino>
- In-Reply-To
- <1290785563-15339-2-git-send-email-pclouds@gmail.com>
Nguyễn Thái Ngọc Duy wrote:
> +++ b/trace.c
[...]
Show 5 quoted lines
> + trace_printf("setup: git_dir: %s\n", quote_crnl(get_git_dir()));
> + trace_printf("setup: worktree: %s\n", quote_crnl(get_git_work_tree()));
> + trace_printf("setup: cwd: %s\n", quote_crnl(cwd));
> + trace_printf("setup: prefix: %s\n", quote_crnl(prefix));
> +}A few days ago I was tracing something or other and decided that these extra lines are annoying.
Patch 1 moves this code from trace.c to git.c, to contain its impact to a single translation unit (that is, it let me experiment without touching cache.h after that).
Patch 2 removes the repo-setup tracing code, introducing a test-repo-setup helper to take its place in the repo setup tests.
Patch 3 does some cleaning up made possible by patch 2.
Thoughts? Jonathan Nieder (3): setup: do not expose tracing code setup: move debugging code to test-repo-setup helper setup: stop using GIT_TRACE in tests
.gitignore | 1 + Makefile | 1 + cache.h | 1 - git.c | 4 ---- t/t1510-repo-setup.sh | 12 +++++------- test-repo-setup.c | 32 ++++++++++++++++++++++++++++++++ trace.c | 49 ------------------------------------------------- 7 files changed, 39 insertions(+), 61 deletions(-) create mode 100644 test-repo-setup.c
-- 1.7.4.rc3