git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: build deps

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 15, 2012, 20:53 UTC
Message-ID
<7vd30jwj7v.fsf@alter.siamese.dyndns.org>
In-Reply-To
<507C2F6E.9060100@drmicha.warpmail.net>
Michael J Gruber <git@drmicha.warpmail.net> writes:
Show 9 quoted lines
>> grep.c:451:16: warning: comparison of unsigned enum expression < 0 is
>> always false [-Wtautological-compare]
>>                 if (p->field < 0 || GREP_HEADER_FIELD_MAX <= p->field)
>>                     ~~~~~~~~ ^ ~
>> 1 warning generated.
>
> Right, that enum type starts at 0. Junio, you last touched this area.
> Can we just dump the first comparison or did you have something else in
> mind?

I think it was a leftover from the very first implementation that defensively said "this has to be one of these known ones", and tried to bound it from both sides of the range, regaredless of the actual type of the field (these GREP_HEADER_WHAT things may have been simple integers with #define'd values). Dropping the "negative" comparison is perfectly fine.

Previous: Thiago FarinaNext: David Aguilar
Message 11 of 13 in “build deps”
  1. Thiago FarinaOct 8, 2012
  2. Andrew WongOct 8, 2012
  3. Thiago FarinaOct 8, 2012
  4. Thiago FarinaOct 8, 2012
  5. Andrew WongOct 8, 2012
  6. Thiago FarinaOct 11, 2012
  7. Andrew WongOct 12, 2012
  8. Thiago FarinaOct 12, 2012
  9. Michael J GruberOct 15, 2012
  10. Thiago FarinaOct 15, 2012
  11. Junio C HamanoOct 15, 2012
  12. David AguilarOct 16, 2012
  13. Michael J GruberOct 16, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.