git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: build deps

From
Michael J Gruber <git@drmicha.warpmail.net>
Date
Oct 15, 2012, 15:44 UTC
Message-ID
<507C2F6E.9060100@drmicha.warpmail.net>
In-Reply-To
<CACnwZYfmz1BTo6okzFh8jXbw+0MAV0sEanYXNzAnV7L4p7nY_g@mail.gmail.com>
Thiago Farina venit, vidit, dixit 12.10.2012 06:08:
Show 33 quoted lines
> On Thu, Oct 11, 2012 at 10:06 PM, Andrew Wong
> <andrew.kw.w.lists@gmail.com> wrote:
>> On 10/11/12 16:54, Thiago Farina wrote:
>>> Just setting CC to gcc works for me. But still, I'd like to be able to
>>> build with clang (may be as you noted is just something with the + in
>>> my PATH).
>> Oh, I just realized you were using "sudo". The PATH environment was
>> probably not inherited when you use sudo to run "make". So the
>> subsequent shells statred by "make' were not able to find "clang".
> 
> Interesting, thank you for your observation.
> 
> This worked for me now:
> 
> $ git clone  https://github.com/gitster/git
> $ cd git
> $ make configure
> $ ./configure
> $ make
> $ ./git version
> git version 1.8.0.rc2
> 
> clang reported this:
> combine-diff.c:1006:19: warning: adding 'int' to a string does not
> append to the string [-Wstring-plus-int]
>                 prefix = COLONS + offset;
>                          ~~~~~~~^~~~~~~~
> combine-diff.c:1006:19: note: use array indexing to silence this
> warning
>                 prefix = COLONS + offset;
>                                 ^
>                          &      [       ]
> 1 warning generated.
Does
&COLONS[offset]
silence that?
Show 6 quoted lines
> grep.c:451:16: warning: comparison of unsigned enum expression < 0 is
> always false [-Wtautological-compare]
>                 if (p->field < 0 || GREP_HEADER_FIELD_MAX <= p->field)
>                     ~~~~~~~~ ^ ~
> 1 warning generated.
> 

Right, that enum type starts at 0. Junio, you last touched this area. Can we just dump the first comparison or did you have something else in mind?

Michael
Previous: Thiago FarinaNext: Thiago Farina
Message 9 of 13 in “build deps”
  1. Thiago FarinaOct 8, 2012
  2. Andrew WongOct 8, 2012
  3. Thiago FarinaOct 8, 2012
  4. Thiago FarinaOct 8, 2012
  5. Andrew WongOct 8, 2012
  6. Thiago FarinaOct 11, 2012
  7. Andrew WongOct 12, 2012
  8. Thiago FarinaOct 12, 2012
  9. Michael J GruberOct 15, 2012
  10. Thiago FarinaOct 15, 2012
  11. Junio C HamanoOct 15, 2012
  12. David AguilarOct 16, 2012
  13. Michael J GruberOct 16, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.