git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/3] Fix a race condition when reading loose refs

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 19, 2013, 17:24 UTC
Message-ID
<7vd2ri10a1.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20130619160150.GA19139@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 13 quoted lines
> On Wed, Jun 19, 2013 at 08:36:25AM +0200, Michael Haggerty wrote:
>
>> I took Peff's suggestion to use gotos rather than an infinite loop in
>> the last patch, which means that there is no need for the old patch
>> 03/04.
>
> Thanks, this version looks good to me.
>
> I'm sure the Pascal programmers of the world collectively sighed in
> disgust at a code review requesting a for loop turn into a goto, but I
> think it is more readable than the first version. :)
>
> -Peff

Thanks, both. Essentially the first two are the same from the previous round, and the third one gives us "oops, unexpected state---let's retry" in a more straight-forward way.

Looks very sensible; will queue.
Previous: Jeff King
Message 6 of 6 in “Fix a race condition when reading loose refs”
  1. 0/3 Fix a race condition when reading loose refsMichael Haggerty, Jun 19, 2013
  2. 1/3 resolve_ref_unsafe(): extract function handle_missing_loose_ref()Michael Haggerty, Jun 19, 2013
  3. 2/3 resolve_ref_unsafe(): handle the case of an SHA-1 within loopMichael Haggerty, Jun 19, 2013
  4. 3/3 resolve_ref_unsafe(): close race condition reading loose refsMichael Haggerty, Jun 19, 2013
  5. Jeff KingJun 19, 2013
  6. Junio C HamanoJun 19, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.