From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 19 Jun 2013 17:24:38 GMT
Subject: Re: [PATCH v2 0/3] Fix a race condition when reading loose refs
Message-ID: <7vd2ri10a1.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130619160150.GA19139@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Wed, Jun 19, 2013 at 08:36:25AM +0200, Michael Haggerty wrote:
>
>> I took Peff's suggestion to use gotos rather than an infinite loop in
>> the last patch, which means that there is no need for the old patch
>> 03/04.
>
> Thanks, this version looks good to me.
>
> I'm sure the Pascal programmers of the world collectively sighed in
> disgust at a code review requesting a for loop turn into a goto, but I
> think it is more readable than the first version. :)
>
> -Peff

Thanks, both.  Essentially the first two are the same from the
previous round, and the third one gives us "oops, unexpected
state---let's retry" in a more straight-forward way.

Looks very sensible; will queue.