Re: [PATCH v5 4/5] pretty: Add failing tests: user format ignores i18n.logOutputEncoding setting

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 20, 2013, 20:23 UTC
Message-ID: <7vd2rgsf93.fsf@alter.siamese.dyndns.org>
In-Reply-To: <297a5bacde1eb3cbe96a05e8ddf1783c44cba4ac.1371720245.git.Alex.Crezoff@gmail.com>

Alexey Shumkin <Alex.Crezoff@gmail.com> writes:

Show 7 quoted lines

> @@ -19,7 +23,8 @@ add_file () {
>  			echo "$name" >"$name" &&
>  			git add "$name" &&
>  			test_tick &&
> -			git commit -m "Add $name" || exit
> +			msg_added_iso88595=$(echo "Add $name ($added $name)" | iconv -f utf-8 -t iso88595) &&
> +			git -c 'i18n.commitEncoding=iso88595' commit -m "$msg_added_iso88595"

Hmph. Do we know 8859-5 is available or do these need to be protected with prereq?

Can these tests be done with 8859-1 i.e. something we already depend on, by changing that $added message to latin-1, or is there something very Russian specific breakage we want to test here?

If the former, please redo this entire patch (not just t4041) with 8859-1.

If there is some Russian specific breakage you cannot demonstrate with 8859-1, then please explain it in the log message.

Show 9 quoted lines

> diff --git a/t/t6006-rev-list-format.sh b/t/t6006-rev-list-format.sh
> index d32e65e..36e4cc0 100755
> --- a/t/t6006-rev-list-format.sh
> +++ b/t/t6006-rev-list-format.sh
> ...
> -# usage: test_format name format_string <expected_output
> +# usage: test_format [failure] name format_string <expected_output
>  test_format () {
> +	local must_fail=0

This breaks tests for non-bash users.  "local" is not even in POSIX.