Re: Gitk feature - show nearby tags

From: Junio C Hamano <junkio@cox.net>
Date: Jun 4, 2006, 10:06 UTC
Message-ID: <7vbqt9ck05.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <e5bfff550606040254n1449b62ta70c209ad8e1a0c@mail.gmail.com>

"Marco Costalba" <mcostalba@gmail.com> writes:

Show 13 quoted lines

> In a less corner case, just to better explaing my idea, consider this:
>
>          a---b---d---e---f---g---h
>          t1   \ /              t3
>             ---c
>                t2
>
> Where our sha1 is still "e", in this case
>
> git-rev-list  --topo-order <e>  ^a  ^c   ^g
>
> gives, as last revision in output list, "f"
> Then parentOf(<f>) is <g> and our looked for tag is t3

Sorry, in the example time flows from left to right. If you exclude g then you are excluding everything that is reachable from g so you would not see "f".

Even if your example is different from what I gave (which had "a" as the root commit) and h is the root commit, your ^a and ^c would exclude everything that is reachable from either a or c, so you would get an empty set. So your "last revision in output" would not be "f" either.