git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Gitk feature - show nearby tags

From
Junio C Hamano <junkio@cox.net>
Date
Jun 4, 2006, 10:10 UTC
Message-ID
<7v7j3xcjti.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<7vbqt9ck05.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> writes:
Show 25 quoted lines
> "Marco Costalba" <mcostalba@gmail.com> writes:
>
>> In a less corner case, just to better explaing my idea, consider this:
>>
>>          a---b---d---e---f---g---h
>>          t1   \ /              t3
>>             ---c
>>                t2
>>
>> Where our sha1 is still "e", in this case
>>
>> git-rev-list  --topo-order <e>  ^a  ^c   ^g
>>
>> gives, as last revision in output list, "f"
>> Then parentOf(<f>) is <g> and our looked for tag is t3
>
> Sorry, in the example time flows from left to right.  If you
> exclude g then you are excluding everything that is reachable
> from g so you would not see "f".
>
> Even if your example is different from what I gave (which had
> "a" as the root commit) and h is the root commit, your ^a and ^c
> would exclude everything that is reachable from either a or c,
> so you would get an empty set.  So your "last revision in
> output" would not be "f" either.

BTW, that was exactly what I meant by "2^N permutations of tags". If you exclude all tags that are older than "e" then your algorithm would work beautifully, but the algorithm is about finding out which tags are older than "e" to begin with, so...

Previous: Junio C HamanoNext: Marco Costalba
Message 11 of 29 in “Gitk feature - show nearby tags”
  1. Paul MackerrasJun 3, 2006
  2. Junio C HamanoJun 3, 2006
  3. Marco CostalbaJun 3, 2006
  4. Paul MackerrasJun 4, 2006
  5. Marco CostalbaJun 4, 2006
  6. Junio C HamanoJun 4, 2006
  7. Marco CostalbaJun 4, 2006
  8. Junio C HamanoJun 4, 2006
  9. Marco CostalbaJun 4, 2006
  10. Junio C HamanoJun 4, 2006
  11. Junio C HamanoJun 4, 2006
  12. Marco CostalbaJun 4, 2006
  13. Marco CostalbaJun 4, 2006
  14. Junio C HamanoJun 4, 2006
  15. Marco CostalbaJun 4, 2006
  16. Junio C HamanoJun 5, 2006
  17. Marco CostalbaJun 5, 2006
  18. Paul MackerrasJun 3, 2006
  19. Junio C HamanoJun 3, 2006
  20. Paul MackerrasJun 4, 2006
  21. Jonas FonsecaJun 3, 2006
  22. Jakub NarebskiJun 3, 2006
  23. Jonas FonsecaJun 3, 2006
  24. Junio C HamanoJun 4, 2006
  25. Jonas FonsecaJun 5, 2006
  26. Junio C HamanoJun 5, 2006
  27. Junio C HamanoJun 5, 2006
  28. Jonas FonsecaJun 5, 2006
  29. Jonas FonsecaJun 5, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.