Re: [PATCH v2 3/3] send-pack: assign remote errors to each ref

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 14, 2007, 01:41 UTC
Message-ID: <7vbq9xpprg.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20071113113710.GC15880@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> This lets us show remote errors (e.g., a denied hook) along
> with the usual push output. ...

Yay!

Show 6 quoted lines

> ... There are two drawbacks to this
> change:
>
>   1. cross-referencing the incoming status with the ref list
>      is worst case O(n^2) (where n = number of refs); this
>      can be fixed with a smarter implementation

Sure.

Show 9 quoted lines

>   2. the status parsing is not foolproof. We get a line like
>
>          ng refs/heads/master arbitrary msg
>
>      which cannot be parsed unambiguously in the face of
>      refnames with spaces. We do a prefix-match so that
>      you will only run into problems if you have two refs,
>      one of which is a prefix match of the other, and the
>      longer having a space right after the prefix.

Is it really "arbitrary msg", or just a fixed set of strings?

Also I think we can rely on the order report-status extension reports the per-ref result. It gives back the information the same order send-pack side supplies the head information, no?