Re: [PATCH v2 3/3] send-pack: assign remote errors to each ref

From: Jeff King <peff@peff.net>
Date: Nov 15, 2007, 04:54 UTC
Message-ID: <20071115045414.GC9794@sigill.intra.peff.net>
In-Reply-To: <Pine.LNX.4.64.0711140159550.4362@racer.site>

On Wed, Nov 14, 2007 at 02:01:14AM +0000, Johannes Schindelin wrote:

> Since when can refnames contain spaces?  In my copy of git, bad_ref_char() 
> in refs.c returns 1 if ch <= ' '.  It's the first error path, even.

Oops, I'm clearly an idiot. I explicitly looked at bad_ref_char before writing the original message, and somehow read that as strictly less than.

So the parsing problem goes away, and I think using the sort order as a hint takes away the potential performance problem (I don't even know if it was a problem -- there may be other O(n^2) behavior).

I will take a look at the tests Alex has been working on, maybe add a few to it, and submit a cleaned-up series.

-Peff