git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Don't fail when an existing directory can't be created.

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 22, 2008, 22:35 UTC
Message-ID
<7vbpzk7k5x.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<87pro1pj3l.fsf@lysator.liu.se>
David Kågedal <davidk@lysator.liu.se> writes:
> This makes it possible to install in a writable directory not owned by
> the current user.
> ---
Sign-off?
Show 14 quoted lines
> diff --git a/Documentation/Makefile b/Documentation/Makefile
> index 7a2130a..e6271d8 100644
> --- a/Documentation/Makefile
> +++ b/Documentation/Makefile
> @@ -87,15 +87,15 @@ man7: $(DOC_MAN7)
>  info: git.info gitman.info
>  
>  install: man
> -	$(INSTALL) -d -m 755 $(DESTDIR)$(man1dir)
> -	$(INSTALL) -d -m 755 $(DESTDIR)$(man5dir)
> -	$(INSTALL) -d -m 755 $(DESTDIR)$(man7dir)
> +	-$(INSTALL) -d -m 755 $(DESTDIR)$(man1dir)
> +	-$(INSTALL) -d -m 755 $(DESTDIR)$(man5dir)
> +	-$(INSTALL) -d -m 755 $(DESTDIR)$(man7dir)

Makes me wonder what happens if you failed to create the target directory. Is it deemed to be Ok because the later step of installing the contents will fail anyway?

Previous: David KågedalNext: David Kågedal
Message 2 of 3 in “Don't fail when an existing directory can't be created.”
  1. Don't fail when an existing directory can't be created.David Kågedal, Aug 22, 2008
  2. Junio C HamanoAug 22, 2008
  3. David KågedalAug 23, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.