From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 22 Aug 2008 22:35:22 GMT
Subject: Re: [PATCH] Don't fail when an existing directory can't be created.
Message-ID: <7vbpzk7k5x.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <87pro1pj3l.fsf@lysator.liu.se>

David Kågedal <davidk@lysator.liu.se> writes:

> This makes it possible to install in a writable directory not owned by
> the current user.
> ---

Sign-off?

> diff --git a/Documentation/Makefile b/Documentation/Makefile
> index 7a2130a..e6271d8 100644
> --- a/Documentation/Makefile
> +++ b/Documentation/Makefile
> @@ -87,15 +87,15 @@ man7: $(DOC_MAN7)
>  info: git.info gitman.info
>  
>  install: man
> -	$(INSTALL) -d -m 755 $(DESTDIR)$(man1dir)
> -	$(INSTALL) -d -m 755 $(DESTDIR)$(man5dir)
> -	$(INSTALL) -d -m 755 $(DESTDIR)$(man7dir)
> +	-$(INSTALL) -d -m 755 $(DESTDIR)$(man1dir)
> +	-$(INSTALL) -d -m 755 $(DESTDIR)$(man5dir)
> +	-$(INSTALL) -d -m 755 $(DESTDIR)$(man7dir)

Makes me wonder what happens if you failed to create the target
directory.  Is it deemed to be Ok because the later step of installing the
contents will fail anyway?