git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] diff: color statistics (stat, shortstat, numstat)

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 24, 2009, 23:01 UTC
Message-ID
<7vbpqlac6n.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<1240610808-7285-2-git-send-email-markus.heidelberg@web.de>
Markus Heidelberg <markus.heidelberg@web.de> writes:
Show 6 quoted lines
> stat/shortstat:
> Color added and removed lines and the corresponding signs ('+' and '-')
> in the summary.
>
> numstat:
> Color added and removed lines per file.

I find this extremely unreadable. Also numstat being for porcelain use, I do not see the point.

I think [1/2] that removes the (plain)coloring of the stat summary text is Ok. The code is painting the stat summary in the same color as the filenames in the stat graph, and the default "plain" color happens to be "do not color--just use the terminal default", so it probably does not have any practical difference.

Previous: Jeff KingNext: Markus Heidelberg
Message 5 of 6 in “text in --stat is colored like color.diff.plain”
  1. Markus HeidelbergApr 22, 2009
  2. 1/2 diff: do not color --stat output like patch contextMarkus Heidelberg, Apr 24, 2009
  3. 2/2 diff: color statistics (stat, shortstat, numstat)Markus Heidelberg, Apr 24, 2009
  4. Jeff KingApr 24, 2009
  5. Junio C HamanoApr 24, 2009
  6. Markus HeidelbergApr 25, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.