Re: [PATCH 2/2] diff: color statistics (stat, shortstat, numstat)

From: Markus Heidelberg <markus.heidelberg@web.de>
Date: Apr 25, 2009, 11:09 UTC
Message-ID: <200904251309.39816.markus.heidelberg@web.de>
In-Reply-To: <7vbpqlac6n.fsf@gitster.siamese.dyndns.org>

Junio C Hamano, 25.04.2009:

Show 10 quoted lines

> Markus Heidelberg <markus.heidelberg@web.de> writes:
> 
> > stat/shortstat:
> > Color added and removed lines and the corresponding signs ('+' and '-')
> > in the summary.
> >
> > numstat:
> > Color added and removed lines per file.
> 
> I find this extremely unreadable.

I know one can overdo it with colors, but I don't think it's the case for the stat/shortstat summary line here. Of course this is very subjective and if the consensus is not to have colors there, then it's OK.

> Also numstat being for porcelain use, I
> do not see the point.

It gives you an information that --stat doesn't give you: the exact count of added and removed lines per file. Also for long path names you don't have to bother with --stat=x,y

Having said this, I have to admit that I didn't use it myself up to now.

> I think [1/2] that removes the (plain)coloring of the stat summary text is
> Ok.

Do you mean the whole patch 1/2 is OK or only the summary part and the filenames should stay with plain coloring? I think the former.

> The code is painting the stat summary in the same color as the
> filenames in the stat graph, and the default "plain" color happens to be
> "do not color--just use the terminal default", so it probably does not
> have any practical difference.

Eh, yes, for people setting color.diff.plain