Re: [PATCH/RFC] SunOS grep does not understand -C<n>

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 24, 2009, 06:27 UTC
Message-ID: <7vbpnasiiz.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20090724054144.GC6563@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 16 quoted lines

> On Thu, Jul 23, 2009 at 10:30:07PM -0700, Junio C Hamano wrote:
>
>> I noticed that the first "grep -C1" test in t7002 does not pass on my 
>> SunOS-5.11-i86pc, and that is not because our way to spawn external
>> grep is broken, but because the native grep does not understand -C<n>.
>> 
>> Is it just me and my installation (i.e. I might have failed to install
>> saner grep from the distribution that everybody uses), or everybody on
>> SunOS is using this option himself because our Makefile doesn't do that
>> automatically for them?
>> 
>> Just in case it is the latter, here is a proposed patch.
>
> Yes, I've been building with NO_EXTERNAL_GREP for my test box. The grep
> from Solaris 8, at least, doesn't understand '-e' either, which causes
> it to fail many other tests.

Thanks.

Just to double check, do we have "grep -e" (not "git grep -e") that makes Solaris fail? I didn't notice. Or do you mean "git grep -e" fails without NO_EXTERNAL_GREP?