[PATCH/RFC] FreeBSD iconv function signature is "old"
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 24, 2009, 06:29 UTC
- Message-ID
- <7v7hxysie9.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <7vr5w6tzq8.fsf@alter.siamese.dyndns.org>
I noticed that my build on FreeBSD-7.2-RELEASE-i386 fails without OLD_ICONV=YesPlease.
Is it just me and my installation (i.e. I might have failed to install saner iconv from the port that everybody uses), or is everybody who runs on FreeBSD using this option himself because our Makefile doesn't do that automatically for them?
Just in case it is the latter, here is a proposed patch.
---
Makefile | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/Makefile b/Makefile index bde27ed..9a25c08 100644 --- a/Makefile +++ b/Makefile @@ -777,6 +777,7 @@ ifeq ($(uname_O),Cygwin) endif ifeq ($(uname_S),FreeBSD) NEEDS_LIBICONV = YesPlease + OLD_ICONV = YesPlease NO_MEMMEM = YesPlease BASIC_CFLAGS += -I/usr/local/include BASIC_LDFLAGS += -L/usr/local/lib