git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] branch_merged: fix grammar in warning

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 26, 2011, 08:24 UTC
Message-ID
<7vbp1z8apg.fsf@alter.siamese.dyndns.org>
In-Reply-To
<AANLkTimN2ba8Ab2BRp=sU4NT_e6UYh4HH2L7afgEkHg8@mail.gmail.com>
Jay Soffian <jaysoffian@gmail.com> writes:
Show 18 quoted lines
> On Fri, Feb 25, 2011 at 10:33 PM, Eric Hanchrow <eric.hanchrow@gmail.com> wrote:
>>  builtin/branch.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/builtin/branch.c b/builtin/branch.c
>> index 9e546e4..915f270 100644
>> --- a/builtin/branch.c
>> +++ b/builtin/branch.c
>> @@ -134,7 +134,7 @@ static int branch_merged(int kind, const char *name,
>>            in_merge_bases(rev, &head_rev, 1) != merged) {
>>                if (merged)
>>                        warning("deleting branch '%s' that has been merged to\n"
>> -                               "         '%s', but it is not yet merged to HEAD.",
>> +                               "         '%s', but it has not yet been merged to HEAD.",
>
> You can drop the "it" while you're at it. :-)
>
> j.
Yeah, and we would want a sign-off, too.
Previous: Jay SoffianNext: Eric Hanchrow
Message 3 of 5 in “branch_merged: fix grammar in warning”
  1. branch_merged: fix grammar in warningEric Hanchrow, Feb 26, 2011
  2. Jay SoffianFeb 26, 2011
  3. Junio C HamanoFeb 26, 2011
  4. Eric HanchrowFeb 26, 2011
  5. Junio C HamanoFeb 27, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.