From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 26 Feb 2011 08:24:43 GMT
Subject: Re: [PATCH] branch_merged: fix grammar in warning
Message-ID: <7vbp1z8apg.fsf@alter.siamese.dyndns.org>
In-Reply-To: <AANLkTimN2ba8Ab2BRp=sU4NT_e6UYh4HH2L7afgEkHg8@mail.gmail.com>

Jay Soffian <jaysoffian@gmail.com> writes:

> On Fri, Feb 25, 2011 at 10:33 PM, Eric Hanchrow <eric.hanchrow@gmail.com> wrote:
>>  builtin/branch.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/builtin/branch.c b/builtin/branch.c
>> index 9e546e4..915f270 100644
>> --- a/builtin/branch.c
>> +++ b/builtin/branch.c
>> @@ -134,7 +134,7 @@ static int branch_merged(int kind, const char *name,
>>            in_merge_bases(rev, &head_rev, 1) != merged) {
>>                if (merged)
>>                        warning("deleting branch '%s' that has been merged to\n"
>> -                               "         '%s', but it is not yet merged to HEAD.",
>> +                               "         '%s', but it has not yet been merged to HEAD.",
>
> You can drop the "it" while you're at it. :-)
>
> j.

Yeah, and we would want a sign-off, too.