Re: [PATCH 1/1] status: display "doing what" information in git status

From: Junio C Hamano <gitster@pobox.com>
Date: May 5, 2011, 23:37 UTC
Message-ID: <7vbozg67oj.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1304632126-16733-1-git-send-email-madcoder@debian.org>

Pierre Habouzit <madcoder@debian.org> writes:

Show 8 quoted lines

> @@ -732,6 +805,7 @@ void wt_status_print(struct wt_status *s)
>  		status_printf_ln(s, color(WT_STATUS_HEADER, s), "");
>  	}
>  
> +	wt_status_print_doingwhat(s);
>  	wt_status_print_updated(s);
>  	wt_status_print_unmerged(s);
>  	wt_status_print_changed(s);

I am very surprised that a new call to this function is added here.

As the "You are in middle of" information is useful mostly when you are on detached head, I would have expected that the call would be inside the if/elif chain near the top of wt_status_print() where we say "On branch" vs "Not currently on...", to replace that information that comes from that on_what variable.