git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] status: display "doing what" information in git status

From
Pierre Habouzit <madcoder@debian.org>
Date
May 5, 2011, 23:39 UTC
Message-ID
<20110505233925.GE636@madism.org>
In-Reply-To
<7vbozg67oj.fsf@alter.siamese.dyndns.org>
On Thu, May 05, 2011 at 04:37:00PM -0700, Junio C Hamano wrote:
Show 18 quoted lines
> Pierre Habouzit <madcoder@debian.org> writes:
> 
> > @@ -732,6 +805,7 @@ void wt_status_print(struct wt_status *s)
> >  		status_printf_ln(s, color(WT_STATUS_HEADER, s), "");
> >  	}
> >  
> > +	wt_status_print_doingwhat(s);
> >  	wt_status_print_updated(s);
> >  	wt_status_print_unmerged(s);
> >  	wt_status_print_changed(s);
> 
> I am very surprised that a new call to this function is added here.
> 
> As the "You are in middle of" information is useful mostly when you are on
> detached head, I would have expected that the call would be inside the
> if/elif chain near the top of wt_status_print() where we say "On branch"
> vs "Not currently on...", to replace that information that comes from that
> on_what variable.

It's also useful when you're in the middle of a rebase or during a merge conflict who aren't on a detached head.

-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org
Previous: Junio C HamanoNext: Pierre Habouzit
Message 7 of 19 in “status: display "doing what" information in git status”
  1. 1/1 status: display "doing what" information in git statusPierre Habouzit, May 5, 2011
  2. Sverre RabbelierMay 5, 2011
  3. Pierre HabouzitMay 5, 2011
  4. Michael J GruberMay 6, 2011
  5. Pierre HabouzitMay 6, 2011
  6. Junio C HamanoMay 5, 2011
  7. Pierre HabouzitMay 5, 2011
  8. Pierre HabouzitMay 5, 2011
  9. Junio C HamanoMay 5, 2011
  10. Pierre HabouzitMay 5, 2011
  11. status: display "doing what" information in git statusPierre Habouzit, May 6, 2011
  12. Jakub NarebskiMay 6, 2011
  13. Pierre HabouzitMay 6, 2011
  14. Junio C HamanoMay 6, 2011
  15. Pierre HabouzitMay 6, 2011
  16. Junio C HamanoMay 6, 2011
  17. Matthieu MoyMay 6, 2011
  18. Pierre HabouzitMay 6, 2011
  19. Matthieu MoyMay 6, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.