Re: [PATCH 1/5] git-p4 tests: refactor, split out common functions

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 21, 2011, 02:35 UTC
Message-ID: <7vboue4o6s.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7vfwjq4o96.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 5 quoted lines

> Yeah, something like
>
> 	: start
> 	p4d &
>         echo $! >$pidfile

Obviously I should have written:

	: stop
        pid=$(cat "$pidfile")
	while kill -0 $pid
	do
		kill $pid
		sleep 1
	done

Sorry for the noise.

Show 11 quoted lines

>         : stop
> 	while kill -0 $pidfile
>         do
> 	        kill $pidfile
>                 sleep 1
> 	done
>
>> Finding an unused port is also a pain.
>
> I think the way t55xx series assign LIB_HTTPD_PORT is an acceptable
> compromise.