git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/5] git-p4 filetype handling

From
Luke Diamand <luke@diamand.org>
Date
Sep 23, 2011, 17:56 UTC
Message-ID
<4E7CC843.8080707@diamand.org>
In-Reply-To
<20110918012634.GA4578@arf.padd.com>
On 18/09/11 02:26, Pete Wyckoff wrote:
Show 8 quoted lines
> Here's a series that includes some changes to make
> git-p4 handle p4 filetypes better.  This work was
> inspired by Chris Li, and includes some refactoring
> of the git-p4 tests that grew out of looking at
> Vitor's branch changes.
>
> It could use review for generic test beauty, as well
> as for the git-p4 filetype specifics in the code.

Modulo Junio's other comments, this looks sensible to me. I tried it on a sizeable tree and it didn't scramble anything (but that will only have tested the 'normal' filetypes).

Do we use $(some_command) rather than `some_command` now?
A few other small comments to follow.

Regards! Luke

Show 12 quoted lines
>
>   contrib/fast-import/git-p4 |   91 +++++++++++++-----
>   t/lib-git-p4.sh            |   55 +++++++++++
>   t/t9800-git-p4.sh          |  108 ++--------------------
>   t/t9801-git-p4-branch.sh   |  221 ++++++++++++++++++++++++++++++++++++++++++++
>   t/t9802-git-p4-filetype.sh |  107 +++++++++++++++++++++
>   5 files changed, 457 insertions(+), 125 deletions(-)
>
> Thanks,
>
> 		-- Pete
>
Previous: Pete Wyckoff
Message 13 of 13 in “git-p4 filetype handling”
  1. 0/5 git-p4 filetype handlingPete Wyckoff, Sep 18, 2011
  2. 1/5 git-p4 tests: refactor, split out common functionsPete Wyckoff, Sep 18, 2011
  3. Junio C HamanoSep 18, 2011
  4. Pete WyckoffSep 21, 2011
  5. Junio C HamanoSep 21, 2011
  6. Junio C HamanoSep 21, 2011
  7. 2/5 git-p4: handle utf16 filetype properlyPete Wyckoff, Sep 18, 2011
  8. Luke DiamandSep 23, 2011
  9. 2/5 git-p4: handle utf16 filetype properlyPete Wyckoff, Sep 18, 2011
  10. 3/5 git-p4: recognize all p4 filetypesPete Wyckoff, Sep 18, 2011
  11. 4/5 git-p4: stop ignoring apple filetypePete Wyckoff, Sep 18, 2011
  12. 5/5 git-p4: keyword flattening fixesPete Wyckoff, Sep 18, 2011
  13. Luke DiamandSep 23, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.